perf: Assign dereferenced schemas to local vars - #1139
Merged
Conversation
sichanyoo
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
In struct & union serialize / deserialize codegen, dereferenced schemas are assigned to local variables before being captured in consumer blocks. This reduces the amount of work that has to be done in the block versus the current approach, which is to chain long references together.
Variable names are appended with a depth so that nested collections don't shadow the enclosing collection's schema and use the wrong one for serde of the inner collection
In testing, I see measurable performance gains when deserializing nested collections. For simple structures, performance remains largely unchanged.
Tests are added for deeply nested serde as well. Tests are JSON-only since they are primarily intended to test code generation, not any particular encoding.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.