chore: Remove isNull & readNull from ShapeSerializer - #1138
Merged
Conversation
jbelkins
marked this pull request as ready for review
August 4, 2026 20:32
sichanyoo
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes the
isNull()andreadNull()methods fromShapeSerializer. Instead, when a null is encountered while aShapeSerializeris reading, it will throw theDecodedNullerror. This change streamlines the deserializer interface for Swift while not giving up any performance.Reasons:
isNull()is the only method on the deserializer that "looks ahead" at data not yet deserialized. This adds complexity to the deserializer.readNull()is an awkward interface that only may be called onceisNull()has been used to verify that a null is present.The reason for not using this approach cross-platform is that in most languages, throwing an error or exception unwinds the stack & generates a stack trace, which is costly & slow. In Swift, error handling does neither of those things and is therefore fast enough for routine flow control.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.