Skip to content

feat: Add enableAwsChunked context flag #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dayaffe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add enableAwsChunked context flag #1100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Sources/SmithyHTTPAuthAPI/Context/Context+Chunked.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,30 @@

import struct Smithy.AttributeKey
import class Smithy.Context
import class Smithy.ContextBuilder

public extension Context {
var isChunkedEligibleStream: Bool? {
get { get(key: isChunkedEligibleStreamKey) }
set { set(key: isChunkedEligibleStreamKey, value: newValue) }
}

/// Flag controlling whether aws-chunked content encoding may be used for eligible
/// streaming requests. When `false`, aws-chunked encoding is disabled even for
/// eligible streams. Defaults to `true` when unset to preserve existing behavior.
var enableAwsChunked: Bool {
get { get(key: enableAwsChunkedKey) ?? true }
set { set(key: enableAwsChunkedKey, value: newValue) }
}
}

public extension ContextBuilder {
@discardableResult
func withEnableAwsChunked(value: Bool) -> Self {
self.attributes.set(key: enableAwsChunkedKey, value: value)
return self
}
}

private let isChunkedEligibleStreamKey = AttributeKey<Bool>(name: "isChunkedEligibleStreamKey")
private let enableAwsChunkedKey = AttributeKey<Bool>(name: "enableAwsChunkedKey")
1 change: 1 addition & 0 deletions Sources/SmithyHTTPAuthAPI/Context/SigningPropertyKeys.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ public enum SigningPropertyKeys {
public static let clockSkew = AttributeKey<TimeInterval>(name: "ClockSkew")
public static let expiration = AttributeKey<TimeInterval>(name: "Expiration")
public static let isChunkedEligibleStream = AttributeKey<Bool>(name: "isChunkedEligibleStream")
public static let enableAwsChunked = AttributeKey<Bool>(name: "enableAwsChunked")
public static let omitSessionToken = AttributeKey<Bool>(name: "OmitSessionToken")
public static let shouldNormalizeURIPath = AttributeKey<Bool>(name: "ShouldNormalizeURIPath")
public static let signatureType = AttributeKey<AWSSignatureType>(name: "SignatureType")
Expand Down
Loading