feat: Add generic Protocol plugin and protocol interface#348
Merged
Conversation
jterapin
marked this pull request as ready for review
July 8, 2026 21:05
richardwang1124
previously approved these changes
Jul 20, 2026
jterapin
dismissed stale reviews from richardwang1124 and sichanyoo
July 23, 2026 18:05
The base branch was changed.
jterapin
force-pushed
the
define-protocol-plugin
branch
from
July 23, 2026 18:08
7b81439 to
acc261f
Compare
simplecov 1.0.2 ships a public sig/simplecov.rbs that references SkipChunks from their internal-only sigs (sig/internal/) which are not included in the published gem. This breaks rbs validate for any consumer. Ignore the gem-bundled sigs so rbs falls back to the community collection's working signatures.
sichanyoo
self-requested a review
July 23, 2026 18:58
sichanyoo
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Adds the generic
Protocolplugin, aProtocolinterface base class, and aNoOpProtocoldefault: the mechanism for per-client protocol selection built on instance-level plugins (#347).The plugin resolves the
:protocoloption inbefore_initializeand installs build/parse handlers that delegate to the resolved protocol:NoOpProtocolif none.client_class.protocols.Protocol).Protocols are instances (not modules) so they can carry per-client state (e.g.
query_compatible, codec instances).Other Notes
Protocolis a base class our own protocols inherit and a documented interface custom objects merely satisfy — there is deliberately nois_a?(Protocol)check.Symbolto match the rest of the config surface.protocolsregistry (define_singleton_method) since the generated registry isn't restored until the mechanism is hooked up; a TODO marks its removal.