fix: tabbed-set rendering and doc edit links - #27
Merged
Conversation
parseTabGroups consumes the blank lines that follow a tab block, so the emitted <div> markup and the next source line were joined with a single newline. CommonMark treats that as one continuing raw-HTML block, which swallowed whatever came next; headings after tabbed sets rendered as literal '### ...' text. Emit a blank line after the tab-set markup so the HTML block terminates and the following markdown parses. Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
The Edit/Raw links on doc pages still targeted lightseekorg/smg's docs/ tree; the content now lives in this repository under src/lib/content/. Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two doc-page fixes, verified against the production build under
wrangler pages dev:1. Markdown after tabbed sets rendered as literal text (
### PD Disaggregation Workers,## Step 1: Start SMG)parseTabGroupsconsumes the blank lines that follow a=== "Tab"block, so the emitted<div class="doc-tabbed-set">…markup and the next source line were joined by a single newline. CommonMark treats a raw-HTML block as continuing until a blank line, so whatever directly followed a tab widget was swallowed into the HTML block and emitted verbatim. The fix emits a blank line after the tab-set markup, terminating the HTML block.2. Edit/Raw links pointed at the old repo
DocMarkdown.sveltebuiltgithub.com/lightseekorg/smg/edit/main/docs/…URLs; the content now lives in this repository. Links now targetsmg-project/smg-docs/edit/main/src/lib/content/…(raw-URL path verified to return 200).Verification (isolated worktree, port 4180)
/smg/getting-started: zero literal###in the DOM (scripts stripped);PD Disaggregation Workersrenders as<h3>,Step 1: Start SMGas<h2>/smg/concepts/routing/pd-disaggregation,/smg/getting-started/kv-events-cache-aware-routing,/smg/referencelightseekorg/smg/editURLs remainpnpm build/pnpm lintclean; wrangler log free of errors🤖 Generated with Claude Code