Repository navigation
feat(dependabot): require a named sanity check before any merge - #208
Merged
Merged
Conversation
added 2 commits
October 29, 2026 12:23
"Every check green" is not enough where the only check is lint: standards-check never builds or runs code, so a breaking update would merge (dev-env#229). Callers now name their sanity checks, the checks that build or run the code. The gate merges only when each named check ran and passed; a matrix job "test (3.12)" matches "test". No names: the PR is blocked at once, with no runner wait, and labeled dependabot-blocked:no-sanity-check. A named check that never passes keeps the gate polling until the deadline, since checks can register late, then gets the same label. Advances #203
A YAML block scalar gives one check name per line. jq -R read each line as its own input and passed two arrays to --argjson, so the gate failed as cannot-evaluate. Read the whole value with -s and split on commas and newlines. Advances #203
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
dependabot-auto-merge.ymlgets asanity_checksinput: the checks that build or run the code. Lint alone is not enough.no-sanity-check.name (). A missing check keeps the gate polling; at the deadline the PR getsdependabot-blocked:no-sanity-check.Why
All checks green is not proof a bump works when the only checks are lint. Every caller must name a real test or build job before v3 is tagged.
Tests
tests/test-dependabot-auto-merge.sh: 41 pass (10 new). actionlint, shellcheck, markdownlint clean.Advances #203. Advances smartwatermelon/dev-env#229.