Repository navigation
ci(self-review): run the test suite on every PR - #207
Merged
Merged
Conversation
added 2 commits
October 29, 2026 11:54
tests/run-tests.sh ran in no workflow, so changes to the reusable workflows were tested only on the author's machine. #206 changed the Dependabot merge gate with 31 local-only tests. Add a tests job to self-review.yml so the suite runs before a tag moves. Advances smartwatermelon/dev-env#229
The suite calls shellcheck, actionlint, zizmor, yamllint and markdownlint-cli2 (CLAUDE.md). Install the same SHA-verified pins as standards-check.yml, and add self-review.yml to zizmor's adhoc-packages ignore for the same reason standards-check.yml is there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
tests/run-tests.shran in no workflow. #206 changed the Dependabot merge gate with 31 tests that ran only on the author's Mac. Thev3tag should not move until CI runs them.Change
testsjob inself-review.yml: installs the same SHA-verified linter pins asstandards-check.yml, then runsbash tests/run-tests.sh.zizmor.yml:self-review.ymljoinsstandards-check.ymlin theadhoc-packagesignore, for the same reason (single pinned CLI tools, no lockfile).The pins are duplicated from
standards-check.yml; a comment says to change both together.Not in this PR
Making
testsa required check onmainis a branch-protection change for Andrew to decide.Advances smartwatermelon/dev-env#229