Skip to content

-F flag passes string args that could be type-coerced by gh api #43

Closed

Description

@twistedmelonman

Non-Blocking Review Concern: -F flag passes string args that could be type-coerced by gh api

Source: pre-push whole-codebase review
Location: .github/workflows/claude-blocking-review.yml:268
Date: 2026-04-18

What was flagged

-F owner="$OWNER" -F name="$NAME" uses -F (typed) for string GraphQL variables. gh api auto-detects types, so a repo name like "123456" would be coerced to an integer and fail the String! schema. Current repos are safe, but -f (explicit string) for owner/name and -F only for number is the safer form.

Context

This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.


Created by lib-review-issues.sh

Activity

  1. twistedmelonman commented on Apr 18, 2026

    @twistedmelonman
    MemberAuthor

    Resolved. The owner/name portion was fixed in PR #47 (commit 8584ec1, switched -F → -f for String-typed GraphQL variables). The ID! variable on the minimizeComment mutation was fixed in PR #53 (commit d42d068). Both gh api graphql sites in the workflow now use -f for non-Int variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtTechnical debt to address

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions