Feature/devcontainerctl - #7
Conversation
… security scan with detailed configuration
🔒 Trivy Security Scan ResultsStatus: Top 10 Critical/High Severity Vulnerabilities:
📊 Scan Details
Action Run: view run |
🔒 Trivy Security Scan ResultsStatus: Top 10 Critical/High Severity Vulnerabilities:
📊 Scan Details
Action Run: view run |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds automated setup and management scripts for deploying the devcontainer in SDF TRE environments, along with comprehensive documentation updates.
- Introduces
devcontainerctlscript for container lifecycle management with automatic VS Code version alignment - Adds one-time setup script that configures PATH, symlinks, and daily cron jobs
- Updates documentation across README, SDF_TRE_SETUP, and DEVCONTAINER to describe the new automated workflow
- Enables previously commented-out security scanning in the build workflow
- Removes AI assistant extensions (Continue, ChatGPT) from default installation list
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/devcontainerctl | New container management script providing start/stop/restart/update commands with automatic image syncing |
| scripts/setup.sh | New one-time setup script that creates symlinks, configures PATH, and sets up cron jobs |
| SDF_TRE_SETUP.md | Added automated setup section, expanded troubleshooting, and updated documentation for script-based workflow |
| README.md | Added quick setup guide with script usage, updated references to use markdown links |
| DEVCONTAINER.md | Documented new setup scripts, added repository structure for scripts directory, converted file references to markdown links |
| .github/workflows/build-devcontainer.yml | Added disk cleanup step and uncommented security scanning with result processing |
| .devcontainer/vscode-init/extensions-to-install.txt | Commented out Continue and ChatGPT extensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| get_latest_devcontainer() { | ||
| local rc="${1:-false}" | ||
|
|
There was a problem hiding this comment.
[nitpick] This line contains trailing whitespace. Remove it for cleaner code.
DevNiall
left a comment
DevNiall
left a comment
There was a problem hiding this comment.
Points adressed or dismissed
…le naming; improve user feedback during updates
🔒 Trivy Security Scan ResultsStatus: Top 10 Critical/High Severity Vulnerabilities:
📊 Scan Details
Action Run: view run |
This pull request introduces several enhancements to the devcontainer setup, focusing on improved user experience, automation, and documentation. The most significant changes include the addition of user setup scripts for streamlined deployment and management, expanded documentation detailing these scripts, and workflow improvements for disk space management and security scanning. There are also minor updates to extension handling and general documentation clarity.
User Setup & Automation Enhancements
devcontainerctlandsetup.sh) in thescripts/directory, enabling automated container lifecycle management (start, stop, update, etc.) and daily image sync via cron. These scripts simplify deployment, especially in constrained environments like the SDF TRE. [1] [2]README.md,DEVCONTAINER.md,SDF_TRE_SETUP.md) to provide detailed instructions on using the new setup scripts, including quick start guides, usage examples, and explanations of automated features like VS Code tag alignment and proxy inheritance. [1] [2] [3] [4] [5] [6]Workflow & Build Improvements
build-devcontainer.yml) by adding a disk cleanup step before running the security scan to prevent space issues, and fully enabling the Trivy security scan and result processing steps.Documentation & Usability
README.mdandDEVCONTAINER.md, highlighting the new user setup scripts. [1] [2]VS Code Extensions
Continue.continueandopenai.chatgptextensions in.devcontainer/vscode-init/extensions-to-install.txt, TRE LLM service not yet discoverable. [1] [2]General
These changes collectively make the devcontainer easier to deploy, maintain, and use, especially in secure or restricted environments.