Feature/workflow inputs - #4
Merged
Merged
Conversation
…in build workflow
…t and adjust environment variable handling
…variable for consistency
workflow to defer control to devontainer.json or manual input
🔒 Trivy Security Scan ResultsStatus: Top 10 Critical/High Severity Vulnerabilities:
... and 4 more issues. 📊 Scan Details
Action Run: view run |
…ved clarity and flexibility
…clarity on setup and usage
🔒 Trivy Security Scan ResultsStatus: Top 10 Critical/High Severity Vulnerabilities:
... and 4 more issues. 📊 Scan Details
Action Run: view run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the dev container's reproducibility, documentation, and workflow flexibility. The key changes focus on making VS Code Server versioning explicit and overridable, updating documentation to reflect first-class R support, and enhancing the build workflow to support manual version pinning and more robust tagging.
Dev Container Versioning & Build Workflow
VSCODE_COMMITvalue directly in.devcontainer/Dockerfile, making the VS Code Server version explicit and overridable via build args. (.devcontainer/Dockerfile)vscode_commitinput, and improved logic to resolve the VS Code Server commit hash from either workflow input or Dockerfile default, including validation and output of the source. (.github/workflows/build-devcontainer.yml) [1] [2] [3] [4]Documentation & Tagging Strategy
README.mdandDEVCONTAINER.mdto clarify tag families, reproducibility, and the process for pinning VS Code Server versions; also highlighted first-class R support and updated extension management instructions. (README.md,DEVCONTAINER.md) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]SDF_TRE_SETUP.mdto clarify VS Code Server extension extraction and version management, reflecting the new workflow and Dockerfile behavior. (SDF_TRE_SETUP.md) [1] [2] [3]Configuration Flexibility
.devcontainer/devcontainer.jsonto use the local environment variable forVSCODE_COMMIT, supporting local overrides and reproducible builds. (.devcontainer/devcontainer.json)These changes make it easier to reproduce development environments, pin VS Code Server versions for compatibility, and maintain clear documentation for users and contributors.