Skip to content

Feature/devcontainerctl setup - #18

Merged
DevNiall merged 3 commits into
mainfrom
feature/devcontainerctl-setup
Dec 11, 2025
Merged

Feature/devcontainerctl setup#18
DevNiall merged 3 commits into
mainfrom
feature/devcontainerctl-setup

Conversation

@DevNiall

Copy link
Copy Markdown
Contributor

This pull request refactors the devcontainer setup process to improve maintainability, flexibility, and clarity. The main changes include reorganizing how configuration files and scripts are copied and executed in the Docker build, updating the extension download script to accept a custom directory, and enhancing the setup script with better messaging and automated extension installation.

Devcontainer build and configuration process:

  • The Dockerfile now copies the entire .devcontainer directory to /opt/.devcontainer and updates the setup steps to use this new location. It also explicitly creates config directories before copying configuration files, improving clarity and reducing potential errors.
  • The extension download script (02-download-extensions.sh) now accepts an optional target directory argument, making it more flexible for different environments.

Setup script improvements (devcontainerctl/setup.sh):

  • The setup script is renamed from scripts/setup.sh to devcontainerctl/setup.sh, and now installs the VS Code Remote Containers extension automatically if the code command is available, improving user experience.
  • Messaging in the setup script is improved for clarity, with color-coded output for warnings, errors, and verification steps. [1] [2] [3]…tainer lifecycle

@github-actions

Copy link
Copy Markdown

🔒 Trivy Security Scan Results

Status: ⚠️ Vulnerabilities found (see details in artifacts)
Vulnerabilities Found: 88 critical/high severity issues

⚠️ Action Required: Critical or high severity vulnerabilities detected.

Top 10 Critical/High Severity Vulnerabilities:

Type Package Vulnerability Severity Fixed Version
python-pkg Twisted CVE-2022-24801 CRITICAL 22.4.0
node-pkg glob CVE-2025-64756 HIGH 11.1.0, 10.5.0
node-pkg glob CVE-2025-64756 HIGH 11.1.0, 10.5.0
node-pkg grunt CVE-2020-7729 HIGH 1.3.0
node-pkg grunt CVE-2022-1537 HIGH 1.5.3
node-pkg jws CVE-2025-65945 HIGH 3.2.3, 4.0.1
node-pkg npm CVE-2018-7408 HIGH 5.7.1
node-pkg npm CVE-2019-16775 HIGH 6.13.3
node-pkg npm CVE-2019-16776 HIGH 6.13.3
node-pkg npm CVE-2019-16777 HIGH 6.13.4

📊 Scan Details

  • Image: ghcr.io/smartdatafoundry/devcontainer
  • Scan Date: 2025-12-11 20:35:45 UTC
  • Total Vulnerabilities: 88

Action Run: view run
Trivy Report: view report

@DevNiall
DevNiall merged commit 4ed281c into main Dec 11, 2025
1 check failed
@DevNiall
DevNiall deleted the feature/devcontainerctl-setup branch December 11, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant