fix(cubejs): pin cube deps to 1.6.37 for reproducible builds#59
Merged
Conversation
…uilds The Docker build ran `yarn` (non-frozen) against a stale lockfile that pre-dates the `^1.6.37` ranges, so every image build re-resolved the cube packages to the newest published release. That floated to 1.6.68, whose x86_64 `cubestored` binary was not yet published upstream, breaking the cubejs image build (`Cube Store v1.6.68 Artifact ... doesn't exist`). Pin the direct @cubejs-backend/* deps to exact 1.6.37 — the version the service is developed and tested against, and one whose Linux binary exists — so builds are deterministic and no longer chase brand-new releases. cubestore runs as its own container, so the bundled binary version only needs to be a published one. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The cubejs image build (triggered by #58's merge) failed:
Root cause is not #58. The Dockerfile runs
yarn(non-frozen) against a lockfile that pre-dates the^1.6.37ranges inpackage.json, so every build re-resolves the cube packages to the newest release. v1.6.68 was published today at 14:56 UTC — 8 minutes before the build — and its arm64 cubestore binary was up but the x86_64 one (what the CI runner needs) was still uploading.Fix
Pin the 30 direct
@cubejs-backend/*deps to exact1.6.37— the version the service is developed and tested against (.env.exampleCUBESTORE_VERSION=v1.6.37, and what's installed locally), whose Linux binaries are published. Builds are now deterministic and won't chase brand-new upstream releases.cubestoreruns as its own container (base/cubestore.yaml), so the cubejs image only needs a published binary version, not the newest.Follow-up (separate, tested): regenerate the v1 lockfile to reflect 1.6.37 and add
--frozen-lockfileso future drift fails fast instead of floating.🤖 Generated with Claude Code