Auction contract (cameligo + jsligo) - #82
Open
frankhillard wants to merge 7 commits into
Open
Conversation
added 7 commits
July 19, 2022 16:50
ziwot
reviewed
Sep 2, 2022
|
|
||
|
|
||
| let setCommissionFee = ([param, store] : [Parameter.set_fee_param, Storage.t]) : return_ => { | ||
| let _check_admin : unit = Assert.assert_only_admin(store); |
There was a problem hiding this comment.
Suggested change
| let _check_admin : unit = Assert.assert_only_admin(store); | |
| Assert.assert_only_admin(store); |
Also, should have been Assert.onlyAdmin(store); for better readability (and camelCase)
All further binds of function calls returning unit are not necessary
| let _check_auction_not_started : unit = Assert.assert_auction_is_started(currentAuction); | ||
| let _check_auction_not_ended : unit = Assert.assert_auction_is_not_ended(currentAuction); | ||
|
|
||
| let modified_auctions = Big_map.remove(param, store.auctionIdToAuction); |
| @@ -0,0 +1,120 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
these js files can be avoided by using ts-node to execute the ts ones
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "name": "Smarketplace", | |||
| @@ -0,0 +1,121 @@ | |||
|
|
|||
There was a problem hiding this comment.
need tests in jsligo, anyway, we should probably wait for validation of cameligo before spending time of transpilation
frankhillard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.