fix: use Responses API for DeepSeek by default - #300
Open
smallmain wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
DeepSeek's current official documentation states that its API supports the Responses API at
https://api.deepseek.comand documents the supported stateless request/streaming format:https://api-docs.deepseek.com/guides/responses_api/
The project already has a compatible OpenAI Responses provider. The built-in DeepSeek preset was still selecting
openai-chat-completion, so one-click configuration could not use the newly supported interface by default.Validation
npx vitest run test/unit/plan4-provider-catalog.test.ts -t 'uses Responses by default for DeepSeek'- passednpm run compile- passednpm run verify:chat-lib- passednpm run l10n:check- passedgit diff --check- passednpm run test:unit- TypeScript and release checks passed; 103 test files and 1232 tests passed, with one pre-existing catalog assertion failingThe unchanged failing assertion expects every
deepseek-*model to declare FIM. Currentmainaddeddeepseek-v4-flash-vision-expwithout a FIM template in commit616a3bd, so that existing assertion now fails independently of this patch. This PR deliberately leaves that unrelated catalog issue untouched.Fixes #291