Integrate my midnight beta with upstream master

[yoshimo]

This separates quests by minimum build the quest was introduced , preserves comments from both of us and combines the data.

[smaitch]

Why would we want to separate the quests by the minimum build the quest was introduced? And why are you putting all the +0 on the prerequisites (you seem to want to verify them for some reason)?

[yoshimo]

Grouping by build seemed logical and makes it easier to separate them for different expansions.
Some of the requirements were assumed on the beta and need to be verified on release. The? tag didn't exist during beta. The +0 is a hack to make stuff visible. I have yet to find a way to update that in bulk and use the new feature.

[smaitch]

OK, I have been doing some researching. It turns out there should only really be a need for two quest lists. One for the MODERN quests, and one for the CLASSIC quests. At the moment, the MODERN quests would be used by Midnight and Mists of Pandaria Classic, while CLASSIC would be used by World of Warcraft Classic and Burning Crusade Anniversary.
Within each quest list we should ensure that only those quests that are actually in the game are used. We can do this by detecting the expansion and ordering the quests by expansion like you said. In this way we can bail out of processing the quests once all the ones available to the current game are found. This should allow Blizzard to progress with their versions and minimize changes needed to Grail.
I would suggest that the start of the Grail-Quests-MODERN.lua (which is just a rename of Grail-Quests-retain.lua) be:

--
-- Grail Quests
-- Written by scott@mithrandir.com

if not Grail.usesModernQuests then return end

-- We use Grail.expansion to determine when we exit the routine because
-- it tells us what expansion we are currently running in, and the quests
-- are grouped by the expansion in which they were added. If we are not
-- running in a high enough expansion we stop processing the file.

-- Quests that have been removed from the game have a negative expansion.

-- Put all the quests that have been removed from the game here.

if Grail.expansion < 0 then return end

-- Put all the Classic quests here

if Grail.expansion < 1 then return end

-- Put all the Burning Crusade quests here

if Grail.expansion < 2 then return end

-- Put all the Wrath of the Lich King quests here

if Grail.expansion < 3 then return end

-- Put all the Cataclysm quests here

if Grail.expansion < 4 then return end

-- Put all the Mists of Pandaria quests here

if Grail.expansion < 5 then return end

-- Put all the Warlords of Draenor quests here

if Grail.expansion < 6 then return end

-- Put all the Legion quests here

if Grail.expansion < 7 then return end

-- Put all the Battle for Azeroth quests here

if Grail.expansion < 8 then return end

-- Put all the Shadowlands quests here

if Grail.expansion < 9 then return end

-- Put all the Dragonflight quests here

if Grail.expansion < 10 then return end

-- Put all the The War Within quests here

if Grail.expansion < 11 then return end

-- Put all the Midnight quests here

We can still have variations of quests if we really need them by checking the release, but that might go away if we just put entries into the different expansions. The comments that were at the start of the file are moved to the end. And the dailyMaximums and weeklyMaximums would still be at the start of the file.

[yoshimo]

It was also a way to make parsing easier as groups within if-statements are limited in size.
(see the bb88ec4 workaround earlier)
Too bad that 16d7723 broke an entire weekend of fixing the merge conflict and made a new one.

In your new structure we would then introduce new lines and deprecation-tags to override outdated quest info that changed between expansion boundaries, wouldn't we?
Remember the cataclysm or BC where things where removed quite often and changed places.
Remeber 7.3 when quest conditions in suramar were changed

[yoshimo]

Hopefully i didn't introduce errors with the second rebase
I have hidden a few quests that are unavailable on a lvl81 beginner paladin.

[smaitch]

Yes, this change basically means that if there is a change in an expansion we would just have a new line for that quest in the proper expansion. The last quest entry processed is the one that is used in game. You will note that the work has been done for race tags such that old quests that were modified to support Blood Elves, for example, have a version in the older expansion without the Blood Elf tag, and one in later expansions with the Blood Elf. This happens for all race tags (hopefully properly). And of course this can happen for A: or T: tags for NPCs that change, etc.

I have just pushed this latest massive change into the repository. This is a major change. However, I think it is stable right now, but hopefully people will report any issues they find. It should work in all the basic releases that Blizzard has currently (like I have not tried Hardcore or Season of Discovery). However, over time all things like this can be verified.

[yoshimo]

Next time merge my changes before you do the rework ;)

[yoshimo]

@smaitch This is my attempt at logging more data about quests, pins, vignettes and possible triggers based on my work on QuestZoneBroker.
Maybe you can draw inspiration from and forward port this and the quest data to the modern architecture you made so we can sync back up. Might be faster than me pulling my hair out trying ;)

[yoshimo]

@smaitch this is the latest version of mining the map and the last version of quest information i had before you made the big changes. It also includes the version before the rewrite
In case you want to get inspired by some of it and include some of it :)