Enable looking up RuleSets in parent rules - #248
Merged
Conversation
puerco
commented
Jul 29, 2025
| var oldestActive *github.RepositoryRuleset | ||
| for _, rule := range rules { | ||
| ruleset, _, err := ghc.Client().Repositories.GetRuleset(ctx, ghc.Owner(), ghc.Repo(), rule.RulesetID, false) | ||
| ruleset, _, err := ghc.Client().Repositories.GetRuleset(ctx, ghc.Owner(), ghc.Repo(), rule.RulesetID, true) |
Member
Author
There was a problem hiding this comment.
@TomHennen do you have any objections if we enable looking up the rules in parent rules? If this is not enabled, looking up rules defined at the org level returns 404. We can handle the 404 and ignore the rulesets but that means that the control cannot be fulfilled by org-level rules.
Member
Author
|
To repro: # 404s
curl 'https://api.github.com/repos/protobom/protobom/rulesets/969281?includes_parents=false'
# 200 OK
curl 'https://api.github.com/repos/protobom/protobom/rulesets/969281?includes_parents=true' |
This PR changes the API query to allow the client to look for the ContinuityControl controls in parent rules as well. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
TomHennen
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the API query to allow the client to look for the ContinuityControl controls in parent rules. Without this, querying a ruleset's rules return 404.
/cc @TomHennen
Signed-off-by: Adolfo García Veytia (Puerco) puerco@carabiner.dev