Armv8.1-M: Add several missing instructions#420
Open
bremoran wants to merge 8 commits into
Open
Conversation
bremoran
force-pushed
the
keccak-interleave-instructions
branch
from
1a159d1 to
8adfe2d
Compare
mkannwischer
changed the title
mkannwischer
requested changes
Feb 24, 2026
mkannwischer
left a comment
mkannwischer
left a comment
Collaborator
There was a problem hiding this comment.
We have just merged #418, please use the newly added <barrel> shortcut.
Comment on lines
+1050
to
+1051
| class bic_ror(MVEInstruction): | ||
| pattern = "bic <Rd>, <Rn>, <Rm>, ror <imm>" |
Collaborator
There was a problem hiding this comment.
Suggested change
| class bic_ror(MVEInstruction): | |
| pattern = "bic <Rd>, <Rn>, <Rm>, ror <imm>" | |
| class bic_shifted(MVEInstruction): | |
| pattern = "bic <Rd>, <Rn>, <Rm>, <barrel> <imm>" |
Collaborator
There was a problem hiding this comment.
please add the newly added instructions also to instructions.s, so we are testing if this actually works as expected.
Note that paired vmov_double_r2v instructions are destructive, but that this is not currently tracked.
Still does not pass instruction test.
bremoran
force-pushed
the
keccak-interleave-instructions
branch
from
e53e7b5 to
1d900cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that paired vmov_double_r2v instructions are destructive, but that this is not currently tracked.
bic,str,ror,cmp#419