feat: add Hermes and Crush AI agent backend support - #1605
Open
im47cn wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Add two new agent backends: - Hermes (NousResearch): ACP-based agent via `hermes acp`, routed through the existing generic ACP runner (`runAcp`) - Crush (Charmbracelet): HTTP server agent via `crush server`, using a custom `CrushBackend` that spawns the server and communicates via REST API + SSE streaming Both agents are integrated across the monorepo: - happy-cli: CLI subcommands (`happy hermes`, `happy crush`), daemon spawning, AgentId type, SpawnSessionOptions, BackendFlavor - happy-app: Agent type selector, session info display, sync types, agent defaults, persistence Hermes implementation is minimal — just a config entry in KNOWN_ACP_AGENTS and CLI wiring. Crush follows the Agy pattern with a custom AgentBackend implementation and runCrush session runner. 31 tests added covering ACP config resolution and Crush event mapping. 💘 Generated with Crush
im47cn
force-pushed
the
feat/hermes-crush-support-monorepo
branch
from
August 9, 2026 08:11
9ed3fc6 to
fcd642c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for two new AI coding agents:
hermes acpcrush serverChanges
happy-cli (
packages/happy-cli/)Hermes (ACP — minimal changes):
hermestoKNOWN_ACP_AGENTSinacpAgentConfig.ts→hermes acphermescase to daemon agent spawning (routes throughhappy acp hermes)happy hermesdelegates to the genericrunAcp()runner'hermes'toresolveSessionFlavor()andBackendFlavorCrush (custom backend — follows Agy pattern):
src/crush/CrushBackend.ts—AgentBackendimpl that spawnscrush serverwith a Unix socket, communicates via REST API + SSEsrc/crush/runCrush.ts— Session runner following therunAgy.tspatternmapEvent()method for testable event-to-AgentMessagemappinghappy crushand daemon spawn caseShared:
AgentIdtype includes'hermes' | 'crush'SpawnSessionOptions.agentincludes new typesBackendFlavorincludes new typeshappy-app (
packages/happy-app/)agentDefaults.ts:agentKeysarray +normalizeAgentKey()+ defaultspersistence.ts:NewSessionAgentTypeincludes new agentsops.ts:SpawnSessionOptions.agentincludes new typesAgentInput.tsx:agentTypeprop typeTests (31 new tests)
acpAgentConfig.test.ts— Updated to verify Hermes config resolutionhermes.test.ts— Hermes ACP config, args passthroughCrushBackend.test.ts— All 19 crush event-to-message mappingsUsage
Design decisions
runAcp()infrastructure — only a config entry + CLI wiring neededCrushBackend(likeAgyBackend) since Crush doesn't support ACPstatic mapEvent()onCrushBackendfor testability💘 Generated with Crush