fix(create-app): default manual setup to npm - #2703
Merged
antfu merged 3 commits intoAug 19, 2026
Merged
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
Member
|
Let's use https://github.com/antfu-collective/package-manager-detector and fallback to npm. Would you like to update the PR? Thanks |
Contributor
Author
|
@antfu Updated — package manager detection now uses |
antfu
reviewed
Aug 14, 2026
| * @param {string | null} packageManager | ||
| */ | ||
| export function getManualPackageManager(packageManager) { | ||
| return packageManager ?? 'npm' |
Member
There was a problem hiding this comment.
Please minimize the code changes. I don't think this file is necessary
NgoQuocViet2001
force-pushed
the
fix-create-app-manual-npm-fallback
branch
from
August 14, 2026 13:34
3bc39be to
6d7caaf
Compare
antfu
reviewed
Aug 15, 2026
NgoQuocViet2001
force-pushed
the
fix-create-app-manual-npm-fallback
branch
from
August 15, 2026 08:37
6d7caaf to
f45bb98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
create-slidevis run directly with Node, no package manager may be detected. Choosing to install later then producednull installandnull run devin both the generated README and terminal output.package-manager-detectorTests
pnpm --filter create-slidev buildpnpm exec eslint packages/create-app/index.mjs packages/create-app/package.jsonpnpm testcreate-slidevwithout a package-manager user agent and verified the terminal and generated README use npm