Skip to content

fix: force end layout to use dark theme - #2379

Open
elecmonkey wants to merge 2 commits into
slidevjs:mainfrom
elecmonkey:fix/end-page-dark-mode
Open

fix: force end layout to use dark theme#2379
elecmonkey wants to merge 2 commits into
slidevjs:mainfrom
elecmonkey:fix/end-page-dark-mode

Conversation

@elecmonkey

Copy link
Copy Markdown
Contributor

This PR updates the built-in end layout to always render in dark mode.

Previously, the end layout only applied a black background via its own styles, but the surrounding theme context could still be in light mode. As a result, components rendered inside the end layout (such as the built-in PoweredBySlidev component using the text-main class) would pick up light-theme colors, which are not visually correct on a black background.

@netlify

netlify Bot commented Nov 24, 2025

Copy link
Copy Markdown

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 8bdb7f4
🔍 Latest deploy log https://app.netlify.com/projects/slidev/deploys/69dd238c3e812e00096610e7
😎 Deploy Preview https://deploy-preview-2379--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Nov 24, 2025

Copy link
Copy Markdown

Open in StackBlitz

@slidev/client

npm i https://pkg.pr.new/@slidev/client@2379

create-slidev

npm i https://pkg.pr.new/create-slidev@2379

create-slidev-theme

npm i https://pkg.pr.new/create-slidev-theme@2379

@slidev/parser

npm i https://pkg.pr.new/@slidev/parser@2379

@slidev/cli

npm i https://pkg.pr.new/@slidev/cli@2379

@slidev/types

npm i https://pkg.pr.new/@slidev/types@2379

commit: 8bdb7f4

@antfu

antfu commented Apr 28, 2026

Copy link
Copy Markdown
Member

I think it might be better that we don't force the black background nor the dark mode? I think it might be a case where people want light mode end layout?

@kermanx

kermanx commented Apr 28, 2026

Copy link
Copy Markdown
Member

I think it might be better that we don't force the black background nor the dark mode? I think it might be a case where people want light mode end layout?

I think we should instead update the default style for .slidev-layout.end with --uno: dark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants