v1.5.1: Remove Profiles and Semantic Search

[slavashootit]

Summary

Pure cleanup PR — removes Profile system and Semantic Search entirely from the codebase. No new features, no visual changes.

Deleted Files (3)

• Sources/SmartFileSorter/Models/ProfileManager.swift
• Sources/SmartFileSorter/Models/SemanticSearchEngine.swift
• Sources/SmartFileSorter/Views/SemanticSearchView.swift

Modified Files (14)

File	Change
App.swift	Removed ProfileManager.shared init
MainView.swift	Removed profile picker + semantic nav link/route
MenuBarView.swift	Removed profile picker + @ObservedObject
WatcherViewModel.swift	Removed ProfileManager subscription, Combine import, profileName from batch
RuleEngine.swift	Removed currentProfile, renamed rules_Home.json → rules.json + migration
FSEventsWatcher.swift	Removed activeProfile, watcher_paths key + migration from legacy _Home
ScheduleManager.swift	Removed activeProfile, direct watcher_paths key
SorterEngine.swift	Removed activeProfile + profileName from 2 batch sites
HistoryManager.swift	Removed BatchRecord.profileName, profile_name column, DROP COLUMN migration
DashboardView.swift	Removed profile column from CSV export
OnboardingView.swift	Renamed createInitialProfile() → createInitialRule()
CHANGELOG.md	Expanded v1.5.1 entry with ### Changed section
SorterEngineTests.swift	Removed profileName argument
docs/specs/...	Updated design spec with revised acceptance criteria

NLContextualEmbedding Decision

REMOVED — 0 callsites found. SemanticSearchEngine was the only consumer; file deleted entirely.

Migrations (run on first launch after upgrade)

Legacy artifact	Action
rules_Home.json	moveItem → rules.json
watcher_paths_Home UD key	Copy → watcher_paths, remove old key
profile_name SQLite column	ALTER TABLE DROP COLUMN
embeddings SQLite table	DROP TABLE IF EXISTS
profiles.json on disk	Silently ignored

---

Review Feedback Addressed (Round 2)

What changed

1. rules_Home.json → rules.json — RuleEngine now uses rules.json with migration from legacy name
2. watcher_paths_Home → watcher_paths — FSEventsWatcher migrates on restore, removes old key
3. activeProfile eliminated — removed from FSEventsWatcher, ScheduleManager, SorterEngine, HistoryManager (was hardcoded to "Home")
4. BatchRecord.profileName deleted — field, init param, CodingKeys, decoder, SQLite column, INSERT/SELECT queries, CSV export column
5. Test fixed — profileName: nil → argument removed entirely
6. CHANGELOG expanded — ### Changed section added
7. Design spec updated — revised acceptance criteria with migration table

Grep Evidence

$ grep -rin "activeProfile\|currentProfile" Sources/
(0 results) ✅

$ grep -rin "ProfileManager" Sources/ Tests/
(0 results) ✅

$ grep -rin "SemanticSearch" Sources/ Tests/
(0 results) ✅

$ grep -rin "profile" Sources/ --include="*.swift"
HistoryManager.swift:146: // v1.5.1 migration: drop profile_name column
HistoryManager.swift:148: try? execute(sql: "ALTER TABLE batches DROP COLUMN profile_name;")
(2 results — migration SQL only) ✅

$ grep -rin "_Home" Sources/ --include="*.swift"
RuleEngine.swift:130-135: migration code (rules_Home.json → rules.json)
FSEventsWatcher.swift:108-113: migration code (watcher_paths_Home → watcher_paths)
(migration code only — reads legacy keys to delete them) ✅

Stats

• 18 files changed across all commits
• 0 errors, 0 warnings on swift build