Skip to content

Adding Sound output plugin - #3

Open
theZiz wants to merge 11 commits into
slaeshjag:masterfrom
theZiz:sound-output
Open

Adding Sound output plugin#3
theZiz wants to merge 11 commits into
slaeshjag:masterfrom
theZiz:sound-output

Conversation

@theZiz

@theZiz theZiz commented Feb 16, 2017

Copy link
Copy Markdown

This pull request adds a new plugin (https://pyra-handheld.com/boards/threads/sound-output-plugin-for-pandora-configbutton.79781/) for KickAss' pas.sh script for the easy use of bluetooth headsets over alsa (https://pyra-handheld.com/boards/threads/pandora-audio-switch.77143/).

It is tested by three persons and did not show any bugs (anymore).

Furthermore the PR improves the Makefile of the plugins, so that they can be installed if compiled on the pandora, and that you can compile just one plugin instead of all and that you can compile in parallel. It also makes the Makefile shorter and a new plugin does not need to edit the Makefile add all as just all C files in the plugin folder are compiled.

@slaeshjag

Copy link
Copy Markdown
Owner

Look alright. A few minor things:
Indentation is all over the place in configbutton.h, it should be consistent file-wide
Embedding the zip as base64 seems very silly, you could just link it in as a hunk of binary data. See http://stackoverflow.com/questions/4864866/c-c-with-gcc-statically-add-resource-files-to-executable-library/11622727#11622727

@theZiz

theZiz commented Feb 16, 2017

Copy link
Copy Markdown
Author

Sounds interesting, I will have a look at it. Although I like the file inside a header approach :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants