Adding Sound output plugin - #3
Open
theZiz wants to merge 11 commits into
Open
Conversation
Owner
|
Look alright. A few minor things: |
Author
|
Sounds interesting, I will have a look at it. Although I like the file inside a header approach :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new plugin (https://pyra-handheld.com/boards/threads/sound-output-plugin-for-pandora-configbutton.79781/) for KickAss' pas.sh script for the easy use of bluetooth headsets over alsa (https://pyra-handheld.com/boards/threads/pandora-audio-switch.77143/).
It is tested by three persons and did not show any bugs (anymore).
Furthermore the PR improves the Makefile of the plugins, so that they can be installed if compiled on the pandora, and that you can compile just one plugin instead of all and that you can compile in parallel. It also makes the Makefile shorter and a new plugin does not need to edit the Makefile add all as just all C files in the plugin folder are compiled.