Skip to content

FIX: legend sync, theme, and click handling - #236

Merged
YektaY merged 2 commits into
mainfrom
yektay/deactivating_pvs
Mar 17, 2026
Merged

FIX: legend sync, theme, and click handling#236
YektaY merged 2 commits into
mainfrom
yektay/deactivating_pvs

Conversation

@YektaY

@YektaY YektaY commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Legend entries now properly disappear when curves are toggled off and reappear when toggled back on (uses pyqtgraph's removeItem/addItem since QGraphicsGridLayout doesn't collapse hidden items)
  • Disabled pyqtgraph's built-in legend click-to-toggle which was changing curve visibility without updating the control panel toggles
  • Fixed light mode checkboxes rendering as dark squares (unchecked color was #2A2A2A copied from dark theme)
  • Stylesheet asset URLs now resolve to absolute paths for icon loading

Motivation

Addresses a few small issues

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions

@YektaY
YektaY force-pushed the yektay/deactivating_pvs branch from 34d2191 to f68f500 Compare March 12, 2026 21:08
@YektaY YektaY changed the title FIX: FIX: legend sync, theme, and click handling Mar 12, 2026
@YektaY
YektaY marked this pull request as ready for review March 12, 2026 22:29

@zdomke zdomke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected.

Thank you for making some of these changes. 🙏 They've plagued me for ages. I've had nightmares about these checkboxes.

Comment thread trace/services/theme_manager.py
Comment thread trace/stylesheets/light_mode.qss
@YektaY
YektaY merged commit 32f70b1 into main Mar 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants