Skip to content

FIX: Couldn't Adjust Font Size - #221

Merged
zdomke merged 1 commit into
mainfrom
zdomke/font-issue
Mar 16, 2026
Merged

FIX: Couldn't Adjust Font Size#221
zdomke merged 1 commit into
mainfrom
zdomke/font-issue

Conversation

@zdomke

@zdomke zdomke commented Nov 19, 2025

Copy link
Copy Markdown
Collaborator

Description

An issue with PyDM's font size adjustment options came from our stylesheets defining a font-size for all QWidgets. My solution is to remove the set font-size for all widgets as it seems unnecessary.

A second issue came up with the adjustments whenever a font size was given in the pixel units instead of point units. I changed all fonts to use points instead of pixels.

Motivation

Users couldn't make use of PyDM's font size adjustment options (last worked on in slaclab/pydm#441).

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions

@zdomke zdomke self-assigned this Nov 19, 2025
@zdomke zdomke added the bug Something isn't working label Nov 19, 2025
@zdomke
zdomke requested a review from a team November 19, 2025 23:42
@zdomke
zdomke marked this pull request as ready for review November 19, 2025 23:42
@zdomke
zdomke force-pushed the zdomke/font-issue branch from 0b38f55 to 43500a5 Compare February 6, 2026 00:50
@zdomke
zdomke merged commit 65e68a2 into main Mar 16, 2026
4 checks passed
@zdomke
zdomke deleted the zdomke/font-issue branch March 16, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants