Skip to content

FIX: Hide Bin Count Setting for FormulaCurves #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zdomke merged 1 commit into from
Sep 17, 2025
Merged

FIX: Hide Bin Count Setting for FormulaCurves #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions trace/widgets/curve_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,17 @@ def __init__(self, parent: QWidget, plot: PyDMArchiverTimePlot, curve: TimePlotC
color_row = SettingsRowItem(self, "Color", color_button)
main_layout.addLayout(color_row)

self.bin_count_line_edit = bin_count_line_edit = QLineEdit()
bin_count_line_edit.setMaximumWidth(65)
bin_count_line_edit.returnPressed.connect(self.set_curve_data_bins)
optimized_bin_count = SettingsRowItem(self, "Optimized bin count", bin_count_line_edit)
bin_count = curve.optimized_data_bins
if not bin_count:
bin_count = plot.optimized_data_bins
bin_count_line_edit.setPlaceholderText(str(bin_count))
main_layout.addLayout(optimized_bin_count)
self.bin_count_line_edit = None
if hasattr(curve, "setOptimizedDataBins"):
self.bin_count_line_edit = bin_count_line_edit = QLineEdit()
bin_count_line_edit.setMaximumWidth(65)
bin_count_line_edit.returnPressed.connect(self.set_curve_data_bins)
optimized_bin_count = SettingsRowItem(self, "Optimized bin count", bin_count_line_edit)
bin_count = curve.optimized_data_bins
if not bin_count:
bin_count = plot.optimized_data_bins
bin_count_line_edit.setPlaceholderText(str(bin_count))
main_layout.addLayout(optimized_bin_count)

self.live_toggle = QCheckBox("")
self.live_toggle.setCheckState(Qt.Checked if self.curve.liveData else Qt.Unchecked)
Expand Down Expand Up @@ -116,11 +118,14 @@ def set_archive_data_connection(self, state: Qt.CheckState) -> None:
self.curve.use_archive_data = state == Qt.Checked

def show(self):
# Reset Bin Count LineEdit if it exists
if self.bin_count_line_edit:
self.bin_count_line_edit.setStyleSheet("")
self.bin_count_line_edit.setText("")

parent_pos = self.parent().rect().bottomRight()
global_pos = self.parent().mapToGlobal(parent_pos)
self.move(global_pos)
self.bin_count_line_edit.setStyleSheet("")
self.bin_count_line_edit.setText("")
super().show()

@Slot()
Expand Down
Loading