Skip to content

FIX: Error with AxisItem.set_active & Curve Artifacts Remaining on Previous Axis - #200

Merged
zdomke merged 3 commits into
mainfrom
small_fixes
Sep 17, 2025
Merged

FIX: Error with AxisItem.set_active & Curve Artifacts Remaining on Previous Axis#200
zdomke merged 3 commits into
mainfrom
small_fixes

Conversation

@YektaY

@YektaY YektaY commented Sep 16, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR addressed two errors.

  1. In AxisItem.set_active, check that children widgets are CurveItems
  2. When CurveItems are moved to a new AxisItem, the curve's error bar & extension line remained on the previous axis

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions

@zdomke
zdomke requested a review from a team September 17, 2025 18:21
@zdomke zdomke added the bug Something isn't working label Sep 17, 2025
@zdomke zdomke changed the title FIX: Curves leave imprints on old axis and error with active_toggle FIX: Error with AxisItem.set_active & Extension Lines and Error Bars Not Moving to New Axis Sep 17, 2025
@zdomke zdomke changed the title FIX: Error with AxisItem.set_active & Extension Lines and Error Bars Not Moving to New Axis FIX: Error with AxisItem.set_active & Curve Artifacts Remaining on Previous Axis Sep 17, 2025

@zdomke zdomke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this earlier. Found another way to fix the issue with @YektaY and made the changes on his branch (with his permission).

Works for me.

@zdomke
zdomke merged commit 9a10cd5 into main Sep 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants