Skip to content

Curve palette - #199

Merged
zdomke merged 13 commits into
slaclab:mainfrom
michaellans:curve_palette
Oct 9, 2025
Merged

Curve palette#199
zdomke merged 13 commits into
slaclab:mainfrom
michaellans:curve_palette

Conversation

@michaellans

Copy link
Copy Markdown
Collaborator

Description

Added ability to set different color palettes for curves

  • Added new set of color palettes to config.json
  • color_palette in config.py changed to dictionary of lists of colors constructed from json file
  • Created a new curve_color_palette_modal widget to preview and select curve color palettes
  • Added curve palette option to plot settings and axis settings
  • Added logic for selecting default global color palette, applying global palette, and applying palettes per axis

Motivation

Gives users the ability change the palette for new curves, and apply palettes to existing curves globally and for each axis

@zdomke
zdomke requested a review from a team September 15, 2025 20:56
@zdomke zdomke linked an issue Sep 15, 2025 that may be closed by this pull request

@zdomke zdomke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works well.

There are a couple of changes I suggested, but are mostly style changes. The more important comment is about the failing test.

Comment thread trace/widgets/axis_settings.py Outdated
Comment thread trace/config.py Outdated
Comment thread trace/config.py Outdated
Comment thread trace/config.json Outdated
Comment thread trace/widgets/axis_settings.py Outdated
Comment thread trace/widgets/plot_settings.py Outdated
@michaellans
michaellans requested a review from zdomke September 21, 2025 03:45

@zdomke zdomke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Thank you for making all those changes.

It does look like some merge conflicts may have been introduced. I think this PR is good to merge in once those conflicts are fixed up.

@zdomke
zdomke self-requested a review October 6, 2025 17:51

@zdomke zdomke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great for me! Thank you for your work on this!

@zdomke
zdomke merged commit ccf166c into slaclab:main Oct 9, 2025
4 checks passed
@zdomke zdomke mentioned this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] - Include default trace color pallet on Plot Config tab

2 participants