Curve palette - #199
Merged
Merged
Conversation
zdomke
approved these changes
Sep 15, 2025
zdomke
left a comment
Collaborator
There was a problem hiding this comment.
Looks great and works well.
There are a couple of changes I suggested, but are mostly style changes. The more important comment is about the failing test.
zdomke
approved these changes
Sep 22, 2025
zdomke
left a comment
Collaborator
There was a problem hiding this comment.
It looks good. Thank you for making all those changes.
It does look like some merge conflicts may have been introduced. I think this PR is good to merge in once those conflicts are fixed up.
zdomke
self-requested a review
October 6, 2025 17:51
zdomke
approved these changes
Oct 9, 2025
zdomke
left a comment
Collaborator
There was a problem hiding this comment.
This works great for me! Thank you for your work on this!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added ability to set different color palettes for curves
Motivation
Gives users the ability change the palette for new curves, and apply palettes to existing curves globally and for each axis