Skip to content

FIX: Checkbox Slots Accept Enum - #196

Merged
zdomke merged 1 commit into
mainfrom
zdomke/state-changed
Sep 8, 2025
Merged

FIX: Checkbox Slots Accept Enum#196
zdomke merged 1 commit into
mainfrom
zdomke/state-changed

Conversation

@zdomke

@zdomke zdomke commented Sep 8, 2025

Copy link
Copy Markdown
Collaborator

Description

Fix an issue with the slots that Checkboxes are connected to. In PyQt5, QCheckBox.stateChanged passed an int, but in PySide6 it passes a python enum CheckState which can't be treated as an int. This PR fixes the slots to take in either an int or CheckState.

Motivation

An effort to upgrade from PyQt5 to Pyside6.

Pre-merge checklist

  • Code works interactively
  • Test suite passes locally
  • Test suite passes on GitHub Actions

@zdomke
zdomke requested a review from YektaY September 8, 2025 17:18
@zdomke zdomke self-assigned this Sep 8, 2025
@zdomke zdomke added the bug Something isn't working label Sep 8, 2025
@zdomke
zdomke marked this pull request as ready for review September 8, 2025 17:53
@zdomke
zdomke merged commit cdc4d52 into main Sep 8, 2025
4 checks passed
@zdomke
zdomke deleted the zdomke/state-changed branch September 8, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants