Skip to content

Live + archive data moved to curve settings - #186

Merged
zdomke merged 5 commits into
slaclab:mainfrom
michaellans:update_curve_settings
Aug 26, 2025
Merged

Live + archive data moved to curve settings#186
zdomke merged 5 commits into
slaclab:mainfrom
michaellans:update_curve_settings

Conversation

@michaellans

@michaellans michaellans commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator
  • Moved live and archive data option check boxes from control panel to curve settings modal
    • Live and archive connection status indicators are still on the control panel, moved them to be inline with label, settings and delete buttons
  • Also added legend on by default to this PR
Screenshot 2025-08-22 at 15 36 59 Screenshot 2025-08-22 at 15 37 10

@YektaY YektaY linked an issue Aug 21, 2025 that may be closed by this pull request
@michaellans
michaellans marked this pull request as ready for review August 22, 2025 22:55
@zdomke
zdomke requested a review from a team August 25, 2025 16:29
@zdomke
zdomke changed the base branch from ui_redesign to main August 25, 2025 16:31

@zdomke zdomke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!!
I found one small merge conflict that I fixed up in eadc53a

@zdomke

zdomke commented Aug 25, 2025

Copy link
Copy Markdown
Collaborator

Closes #168

@zdomke zdomke linked an issue Aug 25, 2025 that may be closed by this pull request
@zdomke
zdomke merged commit f7d44ce into slaclab:main Aug 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] - Live + archive data moved to curve settings [FEATURE] - Legend on by default

2 participants