Skip to content

Fix #148 read/write inside atomic update #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robnagler merged 1 commit into from
Aug 22, 2025
Merged

Fix #148 read/write inside atomic update #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions slicops/pkcli/yaml_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,20 @@ def _pairs():
return key_value_pairs[0].items()
return key_value_pairs[0]

def _update(old, tmp):
nonlocal rv

rv = _read(old).pkupdate(_validate())
pykern.pkyaml.dump_pretty(rv, filename=tmp)

def _validate():
ctx = slicops.ctx.Ctx(base, base)
for k, v in _pairs():
yield k, ctx.fields[k].value_set(v)

p = path(base)
rv = _read(p).pkupdate(_validate())
pykern.pkio.atomic_write(
p,
writer=lambda x: pykern.pkyaml.dump_pretty(rv, filename=x),
)
rv = None
pykern.pkio.atomic_write(p, writer=lambda x: _update(p, x))
return rv


Expand Down