Skip to content

Fix reservation check for slot usernames in EventDefinition class #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabanaty merged 2 commits into from
Jun 4, 2026
Merged

Fix reservation check for slot usernames in EventDefinition class #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3abf207
Fix reservation check in EventDefinition class for slot usernames
kabanaty Jun 4, 2026
73fd4d5
Merge branch 'slaclab:master' into master
kabanaty Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion slac_timing/event_definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def _reserve(self) -> int:
f"Could not reach edef system pv={_SYSTEM.slot_names[num].pvname}"
)
if edef_name == self.name:
if not _SYSTEM.slot_usernames[num].put(str(self.user), wait=True):
if _SYSTEM.slot_usernames[num].put(str(self.user), wait=True) is None:
raise ReservationError(
f"Could not reach edef system pv={_SYSTEM.slot_usernames[num].pvname}"
)
Expand Down
Loading