fix: support Mac App Store Slack data path#6
Merged
Conversation
The Mac App Store version of Slack is sandboxed and stores data in ~/Library/Containers/com.tinyspeck.slackmacgap/ instead of ~/Library/Application Support/Slack/. Auto-detect both locations at startup, preferring the direct-download path. Also improve the error message when neither path is found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/Library/Containers/com.tinyspeck.slackmacgap/Data/Library/Application Support/Slack/instead of~/Library/Application Support/Slack/. SlackStat now auto-detects both locations at startup.Slack Safe Storageservice name, so no Keychain changes needed.Testing
All 46 tests pass. The
testSlackDataPathDetectiontest now verifies the resolved path matches one of the two known locations.