fix: handle Threads deep link and relative time display#5
Merged
Conversation
Threads in Slack have no deep link URI and the client.counts API does not return a latest timestamp for threads. Fix both issues: - Click Threads now opens Slack to the workspace instead of passing a synthetic channel ID that caused a Slack error page - Thread counts display without a relative time when no timestamp is available (e.g., '🧵 3' instead of '🧵 3 (0s)') - Remove duplicate 'Threads' section header from dropdown menu - Document Threads limitations in README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slack://open?team=) instead of passing a synthetic__threads__channel ID that caused a "Something went wrong" error in Slack. There is noslack://deep link URI for the Threads view.client.countsAPI does not return alatesttimestamp for threads, so thread counts now display without a relative time when unavailable (e.g.,🧵 3instead of🧵 3 (0s)). Added optionallatestfield parsing toThreadCountfor forward-compatibility if Slack adds it.Testing
All 46 tests pass, including 4 new tests:
testSlackDeepLinkForThreads— verifies theslack://open?team=URL formattestThreadCountWithoutLatest— decodes thread withoutlatestfieldtestThreadCountWithLatest— decodes thread withlatestfield and parses datetestMenuBarTitleThreadsWithoutTimestamp— renders thread count without relative time