feat(defect_dojo): make apply_tags_to_findings a configurable import-…#7
Open
slManuel wants to merge 2 commits into
Open
feat(defect_dojo): make apply_tags_to_findings a configurable import-…#7slManuel wants to merge 2 commits into
slManuel wants to merge 2 commits into
Conversation
…scan parameter apply_tags_to_findings was hardcoded to "true" in the import scan driver adapter, forcing the behavior on every consumer. Following the existing configuration pattern (REIMPORT_SCAN, GET_EXACT_PRODUCT), it is now a proper parameter of the import-scan request: - add apply_tags_to_findings to ImportScanRequest (default False) - expose it in ImportScanSerializer (Bool, load_default=False) - read it from the remote config (DEFECT_DOJO.APPLY_TAGS_TO_FINDINGS) with a safe default so consumers without the key are unaffected - the driver adapter serializes request.apply_tags_to_findings instead of the literal "true" Defaults to false to preserve behavior for consumers that do not opt in; set APPLY_TAGS_TO_FINDINGS: true in the remote config to enable it.
Add the new DEFECT_DOJO.APPLY_TAGS_TO_FINDINGS flag to the example remote config (example_remote_config_local) and the engine_core module docs (JSON examples + parameter reference), alongside REIMPORT_SCAN. Defaults to false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…scan parameter
apply_tags_to_findings was hardcoded to "true" in the import scan driver adapter, forcing the behavior on every consumer. Following the existing configuration pattern (REIMPORT_SCAN, GET_EXACT_PRODUCT), it is now a proper parameter of the import-scan request:
Defaults to false to preserve behavior for consumers that do not opt in; set APPLY_TAGS_TO_FINDINGS: true in the remote config to enable it.
Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: