Align Week 1 lessons with runnable checkpoints - #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Week 1 Day 1 is already published, but its first useful test command appears only after the attention theory and does not explain which starter pieces are learner-owned. The supplied attention fixture also omitted a one-leading-dimension case, lost higher-rank coverage while correcting that gap, and treated a supported FP16-on-CPU
mx.addmmcase as unsupported. Finally, the documentedpdm run testpath could keep an older copied fixture instead of activating the current supplied test.The first draft of this repair also left a misleading manual-implementation TODO beside the supplied MLX softmax and turned checkpoint outcomes into test-ledger prose.
Change
linearprecision/device cases against the public MLX oracle.pdm run test --week W --day Drefresh only the selected copied test on every run. The ordinary learner command demonstrates this behavior; this change adds no test-runner or framework self-tests.Review
mainis exactly five existing paths:book/src/week1-01-attention.md,scripts/dev-tools.py,src/tiny_llm/basics.py,src/tiny_llm_ref/basics.py, andtests_refsol/test_week_1_day_1.py(+83/-18).linearis 4 failed; whole Day 1 is 4 passed / 40 failed.linearis 4 passed, Task 2 is 8 passed, and Day 1 is 44 passed. The local full reference suite is 511 passed / 8 skipped after the documented extension builds.tests_refsol/test_dev_tools.pyis restored byte-for-byte tomain.maindeploys GitHub Pages.AI-Assisted: GPT-5.6 Sol + Forge