fix: skip silent daily fallback for unknown freq - #553
Closed
Saswatsusmoy wants to merge 1 commit into
Closed
Conversation
Unrecognized intervals were reindexed to D and forward-filled. Bi-weekly series grew from 8 to 99 rows; 15-minute series with one gap collapsed to 1. Fixes sktime#313
Collaborator
|
Verified on current main: the bi-weekly repro still inflates 8 rows to 99 with frequency_set true; with this branch it stays at 8 rows and transform_data surfaces the frequency_warning. Full suite green, ruff clean. Supersedes #314. The anchor-mismatch variant for recognised frequencies (audit F-01) is tracked separately. |
Shashankss1205
added a commit
that referenced
this pull request
Sep 6, 2026
Squash-merged from #553 by @Saswatsusmoy. Co-authored-by: Saswatsusmoy <Saswatsusmoy@users.noreply.github.com>
Collaborator
|
Landed on main as fa14075 (squash-merged locally because the org policy rejects the merge API for this token). Thanks! |
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #313
Supersedes the approach in #314 (no tests, stale against current
format_data_handle).What does this implement/fix? Explain your changes.
When
pd.infer_freqfails,format_data_handlemapped any unrecognized mode interval tofreq="D", then reindexed the full span and forward/back-filled. That is on by default (SKTIME_MCP_AUTO_FORMAT=true).date_range(..., freq="D")over a sub-day span)transform_datareported this as a successful cleanup (Inferred and set frequency to 'D')The catch-all now leaves frequency unset, skips reindex, and puts a
frequency_warninginchanges_made.transform_dataforwards that warning inchanges_applied. Known intervals (daily with a gap, etc.) still fill as before.Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
elsein the manual freq chain no longer assigns"D"transform_datapath, not only the executor dictAny other comments?
Targeted tests in
tests/test_format_unrecognized_freq.py(issue repro, 15-min collapse, daily gap still filled,transform_datawarning, load → inspect → fit). Related format/load tests passed locally.PR checklist
For all contributions
make check).docs/source/. n/a (no new tool; warning is on the existing format path)examples/. n/a