Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pytorch_forecasting/data/encoders.py
Original file line number Diff line number Diff line change
Expand Up @@ -1568,7 +1568,9 @@ def func(*args, **kwargs):
for key, val in kwargs.items()
}
results.append(getattr(norm, name)(*new_args, **new_kwargs))
return results
return (
all(results) if name == "__sklearn_is_fitted__" else results
)

return func
else:
Expand Down
21 changes: 21 additions & 0 deletions tests/test_data/test_encoders.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import numpy as np
import pandas as pd
import pytest
from sklearn.pipeline import Pipeline
from sklearn.preprocessing import StandardScaler
from sklearn.utils.validation import NotFittedError, check_is_fitted
import torch

Expand Down Expand Up @@ -182,6 +184,25 @@ def test_MultiNormalizer_fitted():
pytest.fail(f"{NotFittedError}")


def test_MultiNormalizer_requires_all_pipeline_normalizers_fitted():
data = np.array([[1.0], [2.0]])
normalizers = [
Pipeline([("scaler", StandardScaler())]),
Pipeline([("scaler", StandardScaler())]),
]
normalizer = MultiNormalizer(normalizers)

with pytest.raises(NotFittedError):
check_is_fitted(normalizer)

normalizers[0].fit(data)
with pytest.raises(NotFittedError):
check_is_fitted(normalizer)

normalizers[1].fit(data)
check_is_fitted(normalizer)


def test_TorchNormalizer_dtype_consistency():
"""
- Ensures that even for float64 `target_scale`, the transformation will not change the prediction dtype.
Expand Down
Loading