[ENH] Implement Baseline forecaster in v2 interface - #2382
Open
Dev10-sys wants to merge 3 commits into
Open
Conversation
Dev10-sys
requested review from
benHeid,
fkiraly,
jdb78 and
phoeenniixx
as code owners
August 16, 2026 11:07
Dev10-sys
force-pushed
the
feature/baseline-v2
branch
3 times, most recently
from
August 16, 2026 11:19
59dd440 to
1bd2fe7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2382 +/- ##
=======================================
Coverage ? 87.93%
=======================================
Files ? 199
Lines ? 11106
Branches ? 0
=======================================
Hits ? 9766
Misses ? 1340
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
phoeenniixx
reviewed
Aug 17, 2026
| "info:name": "Baseline", | ||
| "info:compute": 1, | ||
| "info:y_type": ["numeric"], | ||
| "authors": ["Dev10-sys", "kalpanagola9897"], |
Member
There was a problem hiding this comment.
i think we should also credit the v1 authors
phoeenniixx
reviewed
Aug 17, 2026
| "capability:pred_int": False, | ||
| "capability:flexible_history_length": True, | ||
| "capability:cold_start": False, | ||
| "python_dependencies": [], |
Member
There was a problem hiding this comment.
you dont need to add this, as there are no soft-deps here
phoeenniixx
reviewed
Aug 17, 2026
| def get_test_train_params(cls) -> list[dict[str, Any]]: | ||
| """Return testing parameter settings for trainer fixtures.""" | ||
| params: list[dict[str, Any]] = [ | ||
| {}, |
Member
There was a problem hiding this comment.
can you add more params? like use different losses etc
phoeenniixx
reviewed
Aug 17, 2026
Member
There was a problem hiding this comment.
I htink these tests are already handled by the unified test framework. Do we still need these?
phoeenniixx
requested changes
Aug 17, 2026
phoeenniixx
left a comment
phoeenniixx
left a comment
Member
There was a problem hiding this comment.
Thanks!
I have added some comments pls see above
phoeenniixx
added
enhancement
Dev10-sys
force-pushed
the
feature/baseline-v2
branch
2 times, most recently
from
August 18, 2026 07:25
7d0da85 to
e26ff6a
Compare
Author
Hey @phoeenniixx , sorted out all the feedback pls checkk.. |
Dev10-sys
force-pushed
the
feature/baseline-v2
branch
3 times, most recently
from
August 23, 2026 10:15
a955110 to
05f7225
Compare
Migrates the Baseline forecasting model to the PyTorch Forecasting v2 architecture. Implements Baseline_v2 inheriting from BaseModel for point forecasting using the last observed target, along with Baseline_pkg_v2 inheriting from Base_pkg to manage datamodule and trainer setups. Includes fixture parameter configurations integrated into the estimator compliance test suite.
Dev10-sys
force-pushed
the
feature/baseline-v2
branch
from
August 23, 2026 13:29
05f7225 to
ba02b96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially addresses #1736 and #1992.
What does this implement/fix? Explain your changes.
Adds a v2 implementation of
Baselineforecaster asBaseline_v2.Baseline_v2inheriting fromBaseModelthat repeats the last known target value across prediction horizon.Baseline_pkg_v2inheriting fromBase_pkg.pytorch_forecasting/models/baseline/while maintaining backward compatibility for v1Baseline.tests/test_models/test_baseline_v2.py.What should a reviewer concentrate their feedback on?
Baseline_v2.forwardBaseline_pkg_v2Did you add any tests for the change?
tests/test_models/test_baseline_v2.pywithcheck_estimatorcompliance.PR checklist
tests/test_models/test_baseline_v2.py)