Take HttpClient externally in Vertx Endpoint(Startup)HealthCheck (BREAKING) - #236
Open
sksamuel wants to merge 1 commit into
Open
Take HttpClient externally in Vertx Endpoint(Startup)HealthCheck (BREAKING)#236sksamuel wants to merge 1 commit into
sksamuel wants to merge 1 commit into
Conversation
…AKING) Both Vert.x endpoint checks created their own client via `vertx.createHttpClient()` and never closed it. Each registered instance leaked a pool of connections and netty resources tied to the Vertx instance. Make the constructor take an `io.vertx.core.http.HttpClient` from the caller, who owns the lifecycle. Same change as the Ktor sibling. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking change. Both Vertx endpoint checks created their own `HttpClient` and never closed it. Take the client from the caller, who now owns the lifecycle. Mirrors the same change made on the Ktor side.
Test plan
🤖 Generated with Claude Code