Treat unavailable CPU/load metrics as unhealthy - #202
Open
sksamuel wants to merge 1 commit into
Open
Conversation
`OperatingSystemMXBean.processCpuLoad`, `systemCpuLoad`, and `systemLoadAverage` return a negative value (typically -1.0) when the metric is not available — for example on some Windows JVMs, or when the underlying counter has not yet been initialized. Because `maxLoad` is in the range [0,1], the comparison `-1.0 < maxLoad` is always true, so all three checks silently reported the broken metric as **healthy**. Add an explicit negative-value guard that reports unhealthy with a clear "metric unavailable" message. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SystemCpuHealthCheck,ProcessCpuHealthCheck, andSystemLoadHealthCheckall compare a metric againstmaxLoad ∈ [0,1]without first checking for the sentinel-1.0thatOperatingSystemMXBeanreturns when the metric is unavailable. Since-1.0 < maxLoadis always true, an unsupported platform silently reports healthy.Add an explicit guard that reports unhealthy with a clear "metric unavailable" message.
Test plan
🤖 Generated with Claude Code