Skip to content

Simplify Shadow 9.6 Kotlin DSL structure - #1

Merged
skrcode merged 1 commit into
fix-shadow-9-6-kotlin-dslfrom
review/clean-shadow-9-6-dsl
Aug 31, 2026
Merged

skrcode merged 1 commit into
fix-shadow-9-6-kotlin-dslfrom
review/clean-shadow-9-6-dsl

Conversation

@skrcode

@skrcode skrcode commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Purpose

This is a fork-only review PR against the branch used by upstream PR IntellectualSites#3639. It does not target the upstream repository.

What changed

  • move relocation declarations onto the outer ShadowJar receiver;
  • keep dependency inclusion and exclusion inside dependencies {};
  • remove shadowJar and this@dependencies receiver qualifications;
  • preserve all FAWE-specific relocations and dependency selections;
  • retain the existing platformName and taskCoordinates captures.

The structure follows the approach used by EngineHub WorldEdit #3010.

Verification

  • JDK 25: ./gradlew --no-daemon --max-workers=2 :build-logic:compileKotlin projects :worldedit-cli:shadowJar :worldedit-core:test :worldedit-bukkit:test :worldedit-cli:test — passed;
  • git diff --check — passed;
  • :worldedit-bukkit:shadowJar reaches adapter preparation but remains blocked before Shadow packaging by the existing Codebook 1.0.14 Unsupported class file major version 69 failure. The same configured Java 25 toolchain is selected when Gradle itself is launched with JDK 21.

Commit: signed off with Signed-off-by: Suraj Rajan <surajkrajan95@gmail.com>.

AI assistance

Prepared using JAIPilot workflow guidance:

  • jaipilot-maintainer-intent
  • jaipilot-fast-execution
  • jaipilot-review-diff

Host model: gpt-5.6-sol
Reasoning effort: xhigh
Service mode: fast
Execution mode: local

Move relocation configuration onto the ShadowJar receiver and keep dependency selection inside the nested dependency filter, matching the structure used by upstream WorldEdit.

Signed-off-by: Suraj Rajan <surajkrajan95@gmail.com>
@skrcode
skrcode merged commit 0807ab8 into fix-shadow-9-6-kotlin-dsl Aug 31, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant