Repository navigation
Simplify Shadow 9.6 Kotlin DSL structure - #1
Merged
Merged
Conversation
Move relocation configuration onto the ShadowJar receiver and keep dependency selection inside the nested dependency filter, matching the structure used by upstream WorldEdit. Signed-off-by: Suraj Rajan <surajkrajan95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is a fork-only review PR against the branch used by upstream PR IntellectualSites#3639. It does not target the upstream repository.
What changed
ShadowJarreceiver;dependencies {};shadowJarandthis@dependenciesreceiver qualifications;platformNameandtaskCoordinatescaptures.The structure follows the approach used by EngineHub WorldEdit #3010.
Verification
./gradlew --no-daemon --max-workers=2 :build-logic:compileKotlin projects :worldedit-cli:shadowJar :worldedit-core:test :worldedit-bukkit:test :worldedit-cli:test— passed;git diff --check— passed;:worldedit-bukkit:shadowJarreaches adapter preparation but remains blocked before Shadow packaging by the existing Codebook 1.0.14Unsupported class file major version 69failure. The same configured Java 25 toolchain is selected when Gradle itself is launched with JDK 21.Commit: signed off with
Signed-off-by: Suraj Rajan <surajkrajan95@gmail.com>.AI assistance
Prepared using JAIPilot workflow guidance:
jaipilot-maintainer-intentjaipilot-fast-executionjaipilot-review-diffHost model:
gpt-5.6-solReasoning effort:
xhighService mode:
fastExecution mode: local