Skip to content

fix(nix): use pkgsStatic for musl deps - #90

Merged
definfo merged 1 commit into
sjtug:masterfrom
definfo:fix-pytorch_wheels
Jun 11, 2026
Merged

fix(nix): use pkgsStatic for musl deps#90
definfo merged 1 commit into
sjtug:masterfrom
definfo:fix-pytorch_wheels

Conversation

@definfo

@definfo definfo commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/repos.rs
Redirect,
}

pub fn simple_intel(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter and proxy are merged into a single closure classify (unified control layer over RouteAction).

@definfo
definfo force-pushed the fix-pytorch_wheels branch from 5157d44 to 33e8326 Compare June 11, 2026 18:33
Also add new mocking tests for pytorch-wheels and nix-channels/store

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the PyPI index crawler used for pytorch-wheels, replaces it with simpler request classification logic, and updates E2E tests to run against local fake upstream/S3 services and a local Nix cache fixture. It also adjusts the AWS S3 client configuration to use request checksums when required.

Changes:

  • Remove pypi_index module + scraper dependency, and simplify pytorch-wheels routing to a RouteAction-based classifier.
  • Expand E2E coverage with local fake upstream/S3 services and a nix-serve-backed fixture for nix-channels/store.
  • Drop large HTML fixtures previously used by the PyPI index crawler tests.

Reviewed changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/repos.rs Replaces filter/proxy booleans with RouteAction classification; updates pytorch-wheels logic and tests.
src/storage.rs Configures AWS S3 client to calculate request checksums when required.
src/pypi_index.rs Removes PyPI index crawler and related logic/tests.
src/main.rs Removes pypi_index module import.
src/common.rs Removes PypiIndexConfig from config model and updates config test expectations.
Cargo.toml Drops scraper dependency.
Cargo.lock Removes transitive dependencies from scraper.
Rocket.toml Removes [default.pypi_index] config section.
tests/config/Rocket.toml Removes [default.pypi_index] config section used by tests.
tests/e2e/default.nix Adds nix/s3/upstream local endpoints and wires in a Nix store fixture + fake services.
tests/e2e/simple.sh Hardens E2E script and adds checks for pytorch-wheels caching and nix store mirroring.
tests/e2e/fake_services.py Adds local fake upstream and fake S3 HTTP services for E2E.
tests/pytorch_wheels/whl.html Removed (no longer needed after deleting PyPI index crawler).
tests/pytorch_wheels/whl_cu130.html Removed (no longer needed after deleting PyPI index crawler).
tests/pytorch_wheels/whl_cu130_torch.html Removed (no longer needed after deleting PyPI index crawler).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/e2e/fake_services.py
Comment thread tests/e2e/simple.sh
@definfo
definfo merged commit 553ac28 into sjtug:master Jun 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants