fix(nix): use pkgsStatic for musl deps - #90
Merged
Conversation
definfo
commented
Jun 11, 2026
| Redirect, | ||
| } | ||
|
|
||
| pub fn simple_intel( |
Contributor
Author
There was a problem hiding this comment.
filter and proxy are merged into a single closure classify (unified control layer over RouteAction).
definfo
force-pushed
the
fix-pytorch_wheels
branch
from
June 11, 2026 18:33
5157d44 to
33e8326
Compare
Also add new mocking tests for pytorch-wheels and nix-channels/store
definfo
force-pushed
the
fix-pytorch_wheels
branch
from
June 11, 2026 18:34
33e8326 to
ffa9493
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes the PyPI index crawler used for pytorch-wheels, replaces it with simpler request classification logic, and updates E2E tests to run against local fake upstream/S3 services and a local Nix cache fixture. It also adjusts the AWS S3 client configuration to use request checksums when required.
Changes:
- Remove
pypi_indexmodule +scraperdependency, and simplifypytorch-wheelsrouting to aRouteAction-based classifier. - Expand E2E coverage with local fake upstream/S3 services and a nix-serve-backed fixture for
nix-channels/store. - Drop large HTML fixtures previously used by the PyPI index crawler tests.
Reviewed changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/repos.rs |
Replaces filter/proxy booleans with RouteAction classification; updates pytorch-wheels logic and tests. |
src/storage.rs |
Configures AWS S3 client to calculate request checksums when required. |
src/pypi_index.rs |
Removes PyPI index crawler and related logic/tests. |
src/main.rs |
Removes pypi_index module import. |
src/common.rs |
Removes PypiIndexConfig from config model and updates config test expectations. |
Cargo.toml |
Drops scraper dependency. |
Cargo.lock |
Removes transitive dependencies from scraper. |
Rocket.toml |
Removes [default.pypi_index] config section. |
tests/config/Rocket.toml |
Removes [default.pypi_index] config section used by tests. |
tests/e2e/default.nix |
Adds nix/s3/upstream local endpoints and wires in a Nix store fixture + fake services. |
tests/e2e/simple.sh |
Hardens E2E script and adds checks for pytorch-wheels caching and nix store mirroring. |
tests/e2e/fake_services.py |
Adds local fake upstream and fake S3 HTTP services for E2E. |
tests/pytorch_wheels/whl.html |
Removed (no longer needed after deleting PyPI index crawler). |
tests/pytorch_wheels/whl_cu130.html |
Removed (no longer needed after deleting PyPI index crawler). |
tests/pytorch_wheels/whl_cu130_torch.html |
Removed (no longer needed after deleting PyPI index crawler). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.