Refactor: Consolidate validSpeciesParams and species_params S3 constructor#432
Open
gustavdelius wants to merge 3 commits into
Open
Refactor: Consolidate validSpeciesParams and species_params S3 constructor#432gustavdelius wants to merge 3 commits into
gustavdelius wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates the species parameter validation and default-filling logic directly into the S3 constructors of the
species_paramsandgiven_species_paramsclasses.Summary of Changes
validGivenSpeciesParams()togiven_species_params.data.frame().w_max,alpha,interaction_resource, etc.) fromvalidSpeciesParams()tospecies_params.data.frame().species_params.species_paramsandgiven_species_params.given_species_paramsmethods to forward to their data.frame S3 constructors, ensuring validation and defaults are always filled in regardless of the starting class.validSpeciesParams()andvalidGivenSpeciesParams()to simply returnspecies_params(species_params)andgiven_species_params(species_params), respectively, serving as lightweight wrappers for S3 constructors.