Refactor default parameter calculators get_gamma/f0/ks_default into S3 generics#429
Open
gustavdelius wants to merge 2 commits into
Open
Refactor default parameter calculators get_gamma/f0/ks_default into S3 generics#429gustavdelius wants to merge 2 commits into
gustavdelius wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors other default parameter calculators into S3 generics with MizerParams-specific methods.
Summary of Changes
Converted
get_gamma_default(),get_f0_default(), andget_ks_default()into S3 generics.Defined specialized implementations
get_gamma_default.MizerParams(),get_f0_default.MizerParams(), andget_ks_default.MizerParams().Added validation tests verifying correct S3 generic dispatch on
MizerParamsfor these three default calculators intests/testthat/test-species_params.R.