Feature/proto creation#4
Conversation
| string key = 1; | ||
| } | ||
|
|
||
| message GetResponse { |
There was a problem hiding this comment.
should return the key back to user as well
| string value = 2; | ||
| } | ||
|
|
||
| message PutResponse { |
There was a problem hiding this comment.
should return key and value back to user as well
| } | ||
|
|
||
| func NewGrpcServer() *grpcServer { | ||
| newStorageConfig := storage.NewConfigWithOpts( |
There was a problem hiding this comment.
see how its done in the http server, you dont build a new storage engine everytime, its a singleton that is shared between all servers, not an instance that is instantiated everytime
| func NewGrpcServer() *grpcServer { | ||
| newStorageConfig := storage.NewConfigWithOpts( | ||
| storage.WithTreeType(tree.BTree), | ||
| storage.WithFilePath("testFile.txt"), |
|
|
||
| func NewGrpcServer() *grpcServer { | ||
| newStorageConfig := storage.NewConfigWithOpts( | ||
| storage.WithTreeType(tree.BTree), |
There was a problem hiding this comment.
see how its done in http server, all these are abstracted from the grpc server
| @@ -0,0 +1,23 @@ | |||
| package storage | |||
|
|
|||
| @@ -0,0 +1,29 @@ | |||
| import SimpleDB | |||
|
|
|||
There was a problem hiding this comment.
is this the client or server, if its the server, its not needed
| @@ -0,0 +1,17 @@ | |||
| import KVStoreService | |||
There was a problem hiding this comment.
also can rename the dreictory to sth like py-cli?
| ) | ||
|
|
||
|
|
||
| class KeyValueServiceServicer(object): |
| import KVStoreService | ||
| from enum.command import Command | ||
|
|
||
| class KVStoreController(): |
There was a problem hiding this comment.
Dont call it controller, controllers mean different things in the cloud and go
2 participants
Feature: attached storage engine to grpc server