Repository navigation
Add opt-in workbook macro projects to craft-python - #1
Open
derechopiano wants to merge 2 commits into
Open
derechopiano wants to merge 2 commits into
derechopiano wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in workbook-project role for the desktop portion of storytold/gridcraft#1566, building on craft-python 0.3.0.
The ordinary manifest and its Run Script, Console, Run File, PY.EVAL, helpers and WordCraft/DeckCraft behavior stay on their existing path.
main.py --workbook-macrosuses the existing App/Channel with a small adapter; no second plugin dispatcher or transport is introduced.plugin-macros.jsonhas a separate provider identity, no duplicate functions/ribbon commands, and opts out of VBA recording and ribbon callbacks.macros/*methods. The host owns persistence, trust, editing UI and the workbook transaction.Host dependency: sirmmo/gridcraft#4, which requires the proposed
pythonProjects/engineCommandscapabilities on top of storytold/gridcraft#1123. An unmodified host refuses the manifest. This is separate from Python-in-cells (#469); form controls, Pyodide and rich editor/output work remain later phases of #1566.Validation:
python -m unittest discover -s tests -v: 68 tests passed, including upstream scripts/console/functions, GridCraft/WordCraft/DeckCraft behavior and the new runtime/adapter checks.