Backport "support 'all' codec accept mode"#2120
Open
orgads wants to merge 2 commits into
Open
Conversation
Add RED (RFC 2198) codec definition to codeclib as a supplemental codec. Modify codec_store_accept_one() to preserve supplemental codecs whose clock rate matches the accepted primary codec. Skip supplemental codecs in codec_store_is_full_answer() since they are optional in SDP answers. Closes sipwise#2100 Change-Id: Ie81f45091c5d3dc55e20896d5a6e7a8361fda2f4 (cherry picked from commit b87ae58)
Add the 'all' keyword for the codec accept option in publish mode: - 'all': keep all codecs supported for transcoding and their supplemental codecs, removing only unsupported ones - 'all' + 'any': keep all codecs from the offer without removing any Closes sipwise#2105 Change-Id: Ic271a5e461703e3b9dba3c0717bfbb9da89a03ca (cherry picked from commit 4be228b)
Contributor
Author
|
@rfuchs I'm not sure about your backport policy, but I'd love to have this in mr26.0, so I can use binary packages instead of maintaining patches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport to mr26.0.