Fix false positive METHOD_RETURN_TYPE_CHANGED for covariant return type overrides (#522) - #523
Merged
Merged
Conversation
…pe overrides (#522) Introduce METHOD_RETURN_TYPE_COVARIANT_CHANGED: when a class overrides an interface or superclass method with a covariant return type, the Java compiler generates a bridge method with the original return type, ensuring binary compatibility. japicmp now detects this pattern (bridge method present + new type is subtype of old type) and reports the change as METHOD_RETURN_TYPE_COVARIANT_CHANGED (binary/source compatible, MINOR semver) instead of the false-positive METHOD_RETURN_TYPE_CHANGED (MAJOR). https://claude.ai/code/session_01S6MqaVyB48WckAALkz6KXM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce METHOD_RETURN_TYPE_COVARIANT_CHANGED: when a class overrides an interface
or superclass method with a covariant return type, the Java compiler generates a bridge
method with the original return type, ensuring binary compatibility. japicmp now
detects this pattern (bridge method present + new type is subtype of old type) and
reports the change as METHOD_RETURN_TYPE_COVARIANT_CHANGED (binary/source compatible,
MINOR semver) instead of the false-positive METHOD_RETURN_TYPE_CHANGED (MAJOR).
https://claude.ai/code/session_01S6MqaVyB48WckAALkz6KXM