Skip to content

Fix increment-version action to fail when no replacements or commit made #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siom79 merged 1 commit into from
May 21, 2026
Merged

Fix increment-version action to fail when no replacements or commit made #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,21 +39,27 @@ def parseCli(argv):


def replaceOldVersion(oldVersion, releaseVersion):
changed = False
for dirpath, dnames, fnames in os.walk("./"):
for f in fnames:
if f.endswith(".md") and not f.startswith("ReleaseNotes"):
filedata = None
with open(os.path.join(dirpath, f), 'r') as file:
filedata = file.read()
filedata = filedata.replace(oldVersion, releaseVersion)
with open(os.path.join(dirpath, f), 'w') as file:
file.write(filedata)
print("Replaced " + oldVersion + " with " + releaseVersion + " in file " + os.path.join(dirpath, f) + ".")
newdata = filedata.replace(oldVersion, releaseVersion)
if newdata != filedata:
with open(os.path.join(dirpath, f), 'w') as file:
file.write(newdata)
print("Replaced " + oldVersion + " with " + releaseVersion + " in file " + os.path.join(dirpath, f) + ".")
changed = True
if not changed:
print("No files were modified. Old version '" + oldVersion + "' not found in any .md file.")
sys.exit(1)
args = ["git", "commit", "-a", "-m", "upgraded version in *.md files to " + releaseVersion]
print("Commiting changes: " + ' '.join(args))
returncode = subprocess.call(args)
if returncode != 0:
print("Commit failed with error code " + str(returncode) + ".")
sys.exit(returncode)


def printHelp():
Expand Down
Loading