Skip to content

Documentation fixes - #84

Merged
trulsf merged 3 commits into
mainfrom
tf/doc_update
Nov 11, 2025
Merged

Documentation fixes#84
trulsf merged 3 commits into
mainfrom
tf/doc_update

Conversation

@trulsf

@trulsf trulsf commented Nov 6, 2025

Copy link
Copy Markdown
Member

I just got access to Claude 4.5 so I took it for a test ride on the documentation of TimeStruct. Most of the suggested changes look good and there were some proper fixes a well. Some of the changes are to align with standard American English, and here I do not have a strong preference.

@trulsf
trulsf requested review from JulStraus and hellemo November 6, 2025 13:42
@trulsf trulsf changed the title Tf/doc update Documentation fixes Nov 6, 2025

@JulStraus JulStraus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good, but I would have preferred British English :) Good to find all our typos and issues in the labels.

@hellemo hellemo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I added a comment where I'm not sure the suggested change is correct, or we should probably clarify/add a bit more explanation/detail.

Comment thread src/strat_scenarios/core_types.jl
@trulsf
trulsf merged commit 04799f4 into main Nov 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants